feat(network): broadcast stress test #2025
Conversation
|
This change is |
eitanm-starkware
force-pushed
the
eitan/broadcast_stress_test
branch
from
69c6105
to
8fab583
Compare
eitanm-starkware
force-pushed
the
eitan/broadcast_stress_test
branch
from
8fab583
to
9365978
Compare
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
eitanm-starkware
force-pushed
the
eitan/broadcast_stress_test
branch
from
ad0ec18
to
a568a60
Compare
|
Artifacts upload triggered. View details here |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2025 +/- ##
===========================================
+ Coverage 40.10% 76.84% +36.73%
===========================================
Files 26 377 +351
Lines 1895 39990 +38095
Branches 1895 39990 +38095
===========================================
+ Hits 760 30729 +29969
- Misses 1100 6978 +5878
- Partials 35 2283 +2248 ☔ View full report in Codecov by Sentry. |
|
Artifacts upload triggered. View details here |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| let vec_size = value.len(); | ||
| let payload_size = vec_size - 12; | ||
| let payload_size = vec_size - METADATA_SIZE; | ||
| let id_and_time = value.split_off(payload_size); |
There was a problem hiding this comment.
The message parsing code should validate that value.len() >= METADATA_SIZE before attempting to split the message. This prevents panics from malformed messages. Consider adding:
if value.len() < METADATA_SIZE {
return Err(NetworkError::InvalidMessageFormat);
}Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
|
Benchmark movements: |
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
|
Artifacts upload triggered. View details here |
|
Benchmark movements: |
No description provided.